You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The timeout duration for the REPL has been increased from 10 -> 30 seconds (to address slow start on JDK 17 tests) and the semaphore permits are drained after each test (to avoid cascading failures, context).
Why are the changes needed?
The GA JDK 17 tests consistently fails as described in the jira issue.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Locally verified by installing and running tests with JDK 17 (both the failure and the subsequent fix).
@LuciferYang To repro, I set JAVA_HOME to /usr/lib/jvm/java-17-openjdk-amd64/ and made sure that sbt is picking this settings up (these lines should be in the log Using /usr/lib/jvm/java-17-openjdk-amd64/ as default JAVA_HOME. Note, this will be overridden by -java-home if it is set.)
This was enough to trigger the failure:
@LuciferYang To repro, I set JAVA_HOME to /usr/lib/jvm/java-17-openjdk-amd64/ and made sure that sbt is picking this settings up (these lines should be in the log Using /usr/lib/jvm/java-17-openjdk-amd64/ as default JAVA_HOME. Note, this will be overridden by -java-home if it is set.) This was enough to trigger the failure:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The timeout duration for the REPL has been increased from 10 -> 30 seconds (to address slow start on JDK 17 tests) and the semaphore permits are drained after each test (to avoid cascading failures, context).
Why are the changes needed?
The GA JDK 17 tests consistently fails as described in the jira issue.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Locally verified by installing and running tests with JDK 17 (both the failure and the subsequent fix).